Fix touch issue when dragging a widget with SVG icon #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/4.8.x |
✅ Backports have been created
|
raplemie
approved these changes
Jan 23, 2024
...-apps/appui-test-app/appui-test-providers/src/ui/providers/WidgetApiStageUiItemsProvider.tsx
Show resolved
Hide resolved
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Use svg icons for some of the widget tabs. * Fix usePointerCaptor to attach to SVGElement correctly. * rush change (cherry picked from commit 2fad12b)
GerardasB
added a commit
that referenced
this pull request
Jan 24, 2024
* Use svg icons for some of the widget tabs. * Fix usePointerCaptor to attach to SVGElement correctly. * rush change (cherry picked from commit 2fad12b) Co-authored-by: GerardasB <[email protected]>
|
@GerardasB |
Yes, a fix for this issue is now available at https://github.com/iTwin/appui/releases/tag/release%2F4.8.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue with incorrect event handling of widget tabs when SVG icon is targeted by a touch device.
Fixes #687
Testing
Tested manually via a standalone test-app.