Fix panel initialization #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehenry9498
approved these changes
Jan 11, 2024
raplemie
reviewed
Jan 12, 2024
| @@ -553,10 +553,11 @@ export function initializePanel( | |||
| maxSize, | |||
| }); | |||
|
|
|||
| const collapsed = panelDef.defaultState !== StagePanelState.Open; | |||
There was a problem hiding this comment.
What is a stagepanel in a "Popup" state (last enum value)? I dont see that used anywhere in the code ? (And, it would mean that when in this stage, the panel is collapsed, which would sound unexpected...) Should the enum value be marked as deprecated ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add additional e2e tests and fix panel initialization quirks introduced with #636
Testing
Added additional e2e tests