-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panel resize issue #668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport release/4.8.x |
✅ Backports have been created
|
joehenry9498
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. Single panel can be resized when no other action has been dispatched. Looks like there are a couple playwright tests that need fixed for the build to complete. Will approve
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Fix panel resize issue. * Rush change. * Add additional e2e test. (cherry picked from commit a892118)
GerardasB
added a commit
that referenced
this pull request
Jan 11, 2024
* Fix panel resize issue. * Rush change. * Add additional e2e test. (cherry picked from commit a892118) Co-authored-by: GerardasB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue that caused the panel to become unresizable due to a transient update handler added after the PANEL_INITIALIZE action was dispatched.
Testing
Tested via standalone test-app with a single right panel in a frontstage.