Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panel resize issue #668

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Fix panel resize issue #668

merged 4 commits into from
Jan 11, 2024

Conversation

GerardasB
Copy link
Collaborator

@GerardasB GerardasB commented Jan 10, 2024

Changes

This PR fixes an issue that caused the panel to become unresizable due to a transient update handler added after the PANEL_INITIALIZE action was dispatched.

Testing

Tested via standalone test-app with a single right panel in a frontstage.

@GerardasB GerardasB requested a review from grigasp January 10, 2024 18:01
@GerardasB GerardasB requested a review from a team as a code owner January 10, 2024 18:01
@GerardasB
Copy link
Collaborator Author

@Mergifyio backport release/4.8.x

Copy link
Contributor

mergify bot commented Jan 10, 2024

backport release/4.8.x

✅ Backports have been created

Copy link
Contributor

@joehenry9498 joehenry9498 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Single panel can be resized when no other action has been dispatched. Looks like there are a couple playwright tests that need fixed for the build to complete. Will approve

@GerardasB GerardasB merged commit a892118 into master Jan 11, 2024
14 of 16 checks passed
@GerardasB GerardasB deleted the fix-panel-resize branch January 11, 2024 09:58
mergify bot pushed a commit that referenced this pull request Jan 11, 2024
* Fix panel resize issue.

* Rush change.

* Add additional e2e test.

(cherry picked from commit a892118)
GerardasB added a commit that referenced this pull request Jan 11, 2024
* Fix panel resize issue.

* Rush change.

* Add additional e2e test.

(cherry picked from commit a892118)

Co-authored-by: GerardasB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants