Virtualized Property Grid: display loader on all loads #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saskliutas
requested changes
Jan 3, 2024
...eact/src/components-react/propertygrid/component/VirtualizedPropertyGridWithDataProvider.tsx
Outdated
Show resolved
Hide resolved
raplemie
reviewed
Jan 5, 2024
...eact/src/components-react/propertygrid/component/VirtualizedPropertyGridWithDataProvider.tsx
Outdated
Show resolved
Hide resolved
ViliusBa
commented
Jan 10, 2024
…m/iTwin/appui into property-grid/change-loader-logic
grigasp
reviewed
Jan 11, 2024
ui/components-react/src/components-react/propertygrid/internal/PropertyGridHooks.ts
Outdated
Show resolved
Hide resolved
…/PropertyGridHooks.ts Co-authored-by: Grigas <[email protected]>
…m/iTwin/appui into property-grid/change-loader-logic
saskliutas
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the logic of
VirtualizedPropertyGridWithDataProviderto display the loading spinner on all selections if delay threshold is met (250 ms currently). Which basically means that if agetDatacall takes longer than the 250 ms to complete a loading spinner will be shown instead of the grid until the call is completed.Testing
Added a test case which replicates the aforementioned situation.