Add a preview feature not to close open widget after docking (drag&drop) into Panel #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raplemie
requested changes
Nov 24, 2023
ui/appui-layout-react/src/appui-layout-react/preview/PreviewFeatures.tsx
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/appui-layout-react/state/DropWidgetActiveTabPreviewReducer.ts
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/appui-layout-react/state/NineZoneAction.ts
Outdated
Show resolved
Hide resolved
raplemie
requested changes
Jan 15, 2024
ui/appui-layout-react/src/test/state/changeActiveTabAfterDragDrop.test.ts
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/test/state/changeActiveTabAfterDragDrop.test.ts
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/appui-layout-react/preview/PreviewFeatures.tsx
Outdated
Show resolved
Hide resolved
raplemie
previously requested changes
Jan 19, 2024
common/changes/@itwin/appui-layout-react/change_activeTab_in_preview_2023-11-24-13-38.json
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/appui-layout-react/preview/PreviewFeatures.tsx
Outdated
Show resolved
Hide resolved
…atures.tsx Co-authored-by: Raphaël LEMIEUX <[email protected]>
common/changes/@itwin/appui-react/change_activeTab_in_preview_2023-11-24-13-38.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added new preview feature:
changeActiveTabAfterDragDropfeature preview. When enabled, whenever a widget or tab is dropped somewhere, it becomes the active tab of the receiving container.Testing
Standalone test app