Use iTwinUI Tab instead of our current one #1190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Investigate: Tabs height is a bit bigger than the div itself. |
GerardasB
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Some issues while playing around with the storybook:
- Widget tabs are bigger in height than the title bar area
- Double borders between tabs (and on first tab)
- Tab labels (and borders) are wrapping outside of tab area
- Dragging a single tab should not undock a whole stacked widget w/ multiple tabs
- No longer possible to drop widget on title bar tab target
FlyersPh9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rewrite our current TabBar/Tabs implementation to use iTwin elements.
Some of the visual changes:
Testing
Tests + manually playing around with tabs.