Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for new editors system #1166

Open
wants to merge 81 commits into
base: master
Choose a base branch
from
Open

Proposal for new editors system #1166

Show file tree
Hide file tree
Changes from 64 commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
13214d2
Initial editor system
saskliutas Oct 28, 2024
2fc52eb
Use new editors in property grid
saskliutas Oct 28, 2024
cdb8778
Use new editors in tools
saskliutas Oct 28, 2024
9aa93d4
Use new editors in imodel-components-react
saskliutas Oct 28, 2024
dfa1a8b
Use new editors in test-app
saskliutas Oct 28, 2024
910c13f
Move formatting stuff to imodel-components-react
saskliutas Dec 9, 2024
7201c83
Cleanup
saskliutas Dec 11, 2024
22c8d3b
Fix types
saskliutas Dec 11, 2024
c52b778
Implement EnumGroupEditor that is compatible with current tools
saskliutas Dec 19, 2024
5fdebac
Document core APIs
saskliutas Dec 19, 2024
12c3105
Cleanup after rebase
saskliutas Dec 20, 2024
6a28cab
No need for base editor props
saskliutas Dec 20, 2024
c780817
Context rename
saskliutas Jan 13, 2025
08da2db
Revert formatting changes
saskliutas Jan 13, 2025
e96e081
Cleanup sample tool
saskliutas Jan 13, 2025
1dc4c5e
Remove leftover peer dep
saskliutas Jan 13, 2025
e7699ba
Hide interop layer
saskliutas Jan 13, 2025
9223e5d
Adjust imodel-components-react
saskliutas Jan 13, 2025
3f1cf36
Cleanup Value related API
saskliutas Jan 13, 2025
d5a1f6c
Remove unused imports
saskliutas Jan 13, 2025
225c1f1
Adjust editors to Value changes
saskliutas Jan 13, 2025
900e09e
Improve editors typing
saskliutas Jan 14, 2025
a5259e7
Update ColorEditor
saskliutas Jan 14, 2025
fd771f3
Fix editors used by sample tool
saskliutas Jan 14, 2025
3f4315e
Mark editors internal;
saskliutas Jan 15, 2025
c0fa724
Add FallbackEditor to render readonly input if no editor is found
saskliutas Jan 15, 2025
13774bd
Move color editor to components-react and add utilities for editor pa…
saskliutas Jan 17, 2025
64027ae
Custom number editor initial attempt
saskliutas Jan 17, 2025
769b614
Add NumericInputEditor
saskliutas Jan 17, 2025
097a191
Add slider editor
saskliutas Jan 17, 2025
800ce7d
Add new editors to sample frontstage
saskliutas Jan 20, 2025
6e6bf3c
Cleanup editor example page UI
saskliutas Jan 21, 2025
216e0f9
Separate Date and DateTime editors to match previous behavior
saskliutas Jan 21, 2025
0b80ebc
Add Checkbox editor as defautl for boolean values
saskliutas Jan 21, 2025
692da90
Move icon to the left side of the input
saskliutas Jan 21, 2025
3f5b6d0
Improve range params handling in NumericInput
saskliutas Jan 21, 2025
52aba50
TextArea editor aka Multiline
saskliutas Jan 21, 2025
0d17886
Move Slider editor to popover
saskliutas Jan 21, 2025
f87a720
Update default editors
saskliutas Jan 21, 2025
d171c03
Cleanup
saskliutas Jan 21, 2025
f525ee7
Remove suffix from typegurads
saskliutas Jan 22, 2025
9206da4
Allow uto set value to undefined in editors
saskliutas Jan 22, 2025
9a171a5
Update comment
saskliutas Jan 22, 2025
4047778
Unify folder naming
saskliutas Jan 22, 2025
e4fd5ab
Convert unefined value to old editor value formtat
saskliutas Jan 22, 2025
89dad90
Cleanup editors specs
saskliutas Jan 22, 2025
ef0eb6f
Replace CommittingEditor component with a hook
saskliutas Jan 23, 2025
46a6d3c
Rename -> . Added alongside and added comment to expalin why they …
saskliutas Jan 23, 2025
df12b4b
Set tool setting editor size to
saskliutas Jan 24, 2025
4fb7556
Remove event handlers from editors that render input component
saskliutas Jan 24, 2025
da58d74
Rename ->
saskliutas Jan 27, 2025
245bd78
Cleanup boolean editor
saskliutas Jan 27, 2025
9a2bd7c
Apply suggestions from code review
saskliutas Jan 30, 2025
a6a0240
Merge branch 'master' into editors/new-system
saskliutas Feb 18, 2025
a6bb3cc
Avoid committing on initial value
saskliutas Feb 18, 2025
76a243d
Commit on blur
saskliutas Feb 18, 2025
914077b
Reuse same property record editor between tool settings and property …
saskliutas Feb 18, 2025
cee291a
Replace applies with isMetadataSupported
saskliutas Feb 18, 2025
cc496f9
Remove presentation from test-app
saskliutas Feb 19, 2025
390ca12
Revert unrelated test-app changes
saskliutas Feb 19, 2025
57f502f
Rename `usedEditor` -> `editorSystem`
saskliutas Feb 19, 2025
6789480
Remove label from EnumValue
saskliutas Feb 19, 2025
224408e
Add e2e tests for the new editors
saskliutas Feb 19, 2025
0d50b7f
Remove new editors from toolsettings for now
saskliutas Feb 20, 2025
6a33eba
Merge branch 'master' into editors/new-system
saskliutas Feb 20, 2025
e8128c9
extract-api
saskliutas Feb 20, 2025
0fb5e61
extract-api
saskliutas Feb 20, 2025
3f0ceca
Exclude new editors from coverage
saskliutas Feb 20, 2025
a385874
Exclude editors from coverage
saskliutas Feb 20, 2025
a55dbe0
Add unit tests
saskliutas Feb 20, 2025
05d4a16
Address PR comments
saskliutas Feb 24, 2025
de626d8
Update comments
saskliutas Feb 24, 2025
315b618
Trim whitespace
saskliutas Feb 24, 2025
3c41e20
cspell
saskliutas Feb 24, 2025
204f47c
Merge branch 'master' into editors/new-system
saskliutas Feb 25, 2025
7d0f2c8
change
saskliutas Feb 28, 2025
ce43196
Merge branch 'master' into editors/new-system
saskliutas Feb 28, 2025
fb82d68
NextVersion
saskliutas Feb 28, 2025
2ba9838
Merge branch 'master' into editors/new-system
saskliutas Mar 4, 2025
b1a399b
Add docs description
saskliutas Mar 5, 2025
4446499
Fix docs
saskliutas Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/test-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
"@itwin/itwinui-icons-react": "^2.8.0",
"@itwin/itwinui-layouts-react": "~0.4.1",
"@itwin/itwinui-layouts-css": "~0.4.0",
"@itwin/presentation-common": "^4.0.0",
"@itwin/reality-data-client": "1.2.2",
"@itwin/webgl-compatibility": "^4.0.0",
"@tanstack/react-router": "^1.87.6",
Expand Down
2 changes: 1 addition & 1 deletion apps/test-app/src/routes/__root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function Root() {
const search = Route.useSearch();
const menu = search.menu !== 0;
return (
<ThemeProvider>
<ThemeProvider theme="os">
<PageLayout>
{menu && (
<PageLayout.Header>
Expand Down
3 changes: 1 addition & 2 deletions apps/test-providers/src/tools/SampleTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ export class SampleTool extends PrimitiveTool {

// Tool Setting Properties
// ------------- Enum based picklist ---------------
// Example of async method used to populate enum values
private _getChoices = async () => {
private _getChoices = () => {
return [
{ label: SampleTool.getOptionString("Red"), value: ToolOptions.Red },
{ label: SampleTool.getOptionString("White"), value: ToolOptions.White },
Expand Down
Loading