Skip to content
This repository was archived by the owner on Nov 21, 2024. It is now read-only.

Add interface definitions for auto fix support #12

Merged
merged 9 commits into from
May 25, 2023
Merged

Conversation

wadimw
Copy link
Contributor

@wadimw wadimw commented May 24, 2023

No description provided.

wadimw added 4 commits May 24, 2023 21:30
- add and export definitions for Fix and Fixer
- include Fix in Result
- include Fixers in Plugin
- add interface for Parser writing back to file
@wadimw wadimw requested a review from ehoogerbeets May 24, 2023 20:34
@wadimw
Copy link
Contributor Author

wadimw commented May 24, 2023

@ehoogerbeets I think it's easier to read in a per-commit manner

@wadimw wadimw mentioned this pull request May 24, 2023
@wadimw
Copy link
Contributor Author

wadimw commented May 24, 2023

Regarding the HTML tags replaced with Markdown syntax in JSDoc, I still left those changes in here because VSCode completely leaves out the parts enclosed in HTML (like lists) so huge chunks of text just didn't render for me at all. I know it's probably uglier in HTML render but should still be readable there. Overall, we need to get this sorted out (and as I said before I think it should be easier to switch to JSDoc with the builtin Markdown plugin; note this is a different issue than the Typescript-specific syntax and given it's built in, it shouldn't be buggy)

- added plugin in jsdoc.json so we can use markdown syntax in the
  the jsdoc comments
- converts to markdown in docs/i18nlint-common.md
- converts to HTML in the docs/index.html
@wadimw wadimw requested a review from ehoogerbeets May 25, 2023 12:38
@wadimw wadimw merged commit d3453b3 into main May 25, 2023
@wadimw wadimw deleted the AutoFixSupport branch May 25, 2023 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants