LCRelationNavigator: add methods to return both max weight and object #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the performance overhead is pretty negligible and I would like the reduced duplication that could be achieved with that. |
|
Ok, I made the change |
|
Ugh I just noticed that the order of the return values in the tuple is the opposite of the method name, let me fix that |
tmadlener
reviewed
Jun 12, 2023
tmadlener
reviewed
Jun 12, 2023
tmadlener
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result from discussion in iLCSoft/MarlinReco#114 (comment)
I was also thinking of changing
getRelatedToMaxWeightand friends to call this and to then just return the respective entry of the tuple to have less of a logic duplication but I have no idea how this will affect the performance...BEGINRELEASENOTES
getRelatedToMaxWeightAndObjectandgetRelatedFromMaxWeightAndObjectreturning both the object and the weight in a tupleENDRELEASENOTES