Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum and default c++ version to 17 #153

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Bump minimum and default c++ version to 17 #153

merged 1 commit into from
Oct 19, 2022

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Make c++17 the default and minimum c++ version for building LCIO. All "major builds" of LCIO have been using c++17 for at least a few years now, so this should not be a big issue.

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

@gaede any concerns about this?

@gaede
Copy link
Contributor

gaede commented Oct 19, 2022

Nope. ;-)

@tmadlener tmadlener merged commit d310a93 into iLCSoft:master Oct 19, 2022
@tmadlener tmadlener deleted the min-cpp-bump branch October 19, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @gaede