Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install all headers that are necessary for python bindings #146

Merged
merged 5 commits into from
May 9, 2022

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

ENDRELEASENOTES

@tmadlener tmadlener force-pushed the fix-pylcio-headers branch 2 times, most recently from e1debee to f3eeff4 Compare March 23, 2022 15:26
@tmadlener tmadlener force-pushed the fix-pylcio-headers branch from f3eeff4 to 5bfe6cd Compare March 23, 2022 15:32
@tmadlener
Copy link
Contributor Author

For some reason this fix works and I can actually use the python bindings when I install everything via spack. However, when trying to build a ROOT version from LCG things fail. As soon as github actions are working again, this should also be visible in the new workflow.

@tmadlener
Copy link
Contributor Author

Aha. CPATH=<prefix>/include seems to do the trick. It looks like that is added by spack automatically, and we could potentially remove the explicit addition of just the <prefix>.

However, I just realized that depending on whether the internal SIO is used or not, we will probably need a few more headers still.

@tmadlener tmadlener force-pushed the fix-pylcio-headers branch 2 times, most recently from d7b71bd to 19566cb Compare March 23, 2022 17:56
@tmadlener tmadlener force-pushed the fix-pylcio-headers branch from 19566cb to 85b5f8f Compare March 23, 2022 18:17
@tmadlener
Copy link
Contributor Author

tmadlener commented Mar 23, 2022

Correction: <prefix> and <prefix>/include seem to be necessary on CPATH. Spack install works without <prefix>/include alone. I don't know why though. I have tried a few of the ususal suspects (ROOT_INCLUDE_PATH, C_INCLUDE_PATH, CPLUS_INCLUDE_PATH) but haven't had any success. Did I miss something obvious?

@tmadlener tmadlener merged commit 3b980c3 into iLCSoft:master May 9, 2022
@tmadlener tmadlener deleted the fix-pylcio-headers branch May 9, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python bindings work only with sources present.
2 participants