Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ILDCellID0 with LCTrackerCellID #9

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Replace ILDCellID0 with LCTrackerCellID #9

merged 1 commit into from
Mar 31, 2017

Conversation

oviazlo
Copy link
Contributor

@oviazlo oviazlo commented Mar 21, 2017 •
edited
Loading

to address issue iLCSoft/LCIO#4

andresailer
andresailer requested changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use angle brackets, add the marked places and amend your commit.

Thanks

Tracking/src/ClicEfficiencyCalculator.cc Outdated
@@ -20,7 +20,7 @@
#include <IMPL/TrackImpl.h>

#include <UTIL/CellIDEncoder.h>
#include <UTIL/ILDConf.h>
#include "UTIL/LCTrackerConf.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the angle brackets

Tracking/src/HitResiduals.cc Outdated
@@ -11,7 +11,7 @@
#include "MarlinTrk/IMarlinTrack.h"

#include <UTIL/BitField64.h>
#include <UTIL/ILDConf.h>
#include "UTIL/LCTrackerConf.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the angle brackets

Tracking/src/TrackChecker.cc Outdated
@@ -23,7 +23,7 @@
#include <IMPL/TrackImpl.h>

#include <UTIL/CellIDEncoder.h>
#include <UTIL/ILDConf.h>
#include "UTIL/LCTrackerConf.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the angle brackets

@oviazlo
Copy link
Contributor Author

oviazlo commented Mar 28, 2017

fixed

@andresailer
Copy link
Contributor

we get

 ***********************************************
 A runtime error occured - (uncaught exception):
      The encoding string was already accessed! Changing it now will lead to inconsistencies! Fix your code!
 Marlin will have to be terminated, sorry.
 ***********************************************

during reconstruction, needs to be investigated, where we access the string already.
Probably conformal tracking
https://github.com/iLCSoft/ConformalTracking/pull/1/files#diff-8fa0895da17afe71e3e8dea58f6c83ccR114

@andresailer
Copy link
Contributor

with iLCSoft/LCIO#19, iLCSoft/Clupatra#7 iLCSoft/MarlinReco#4 this should be running again.

@andresailer andresailer merged commit 99d1a53 into iLCSoft:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees

@andresailer andresailer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oviazlo @andresailer