-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ILDCellID0 with LCTrackerCellID #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use angle brackets, add the marked places and amend your commit.
Thanks
@@ -20,7 +20,7 @@ | |||
#include <IMPL/TrackImpl.h> | |||
|
|||
#include <UTIL/CellIDEncoder.h> | |||
#include <UTIL/ILDConf.h> | |||
#include "UTIL/LCTrackerConf.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the angle brackets
Tracking/src/HitResiduals.cc
Outdated
@@ -11,7 +11,7 @@ | |||
#include "MarlinTrk/IMarlinTrack.h" | |||
|
|||
#include <UTIL/BitField64.h> | |||
#include <UTIL/ILDConf.h> | |||
#include "UTIL/LCTrackerConf.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the angle brackets
Tracking/src/TrackChecker.cc
Outdated
@@ -23,7 +23,7 @@ | |||
#include <IMPL/TrackImpl.h> | |||
|
|||
#include <UTIL/CellIDEncoder.h> | |||
#include <UTIL/ILDConf.h> | |||
#include "UTIL/LCTrackerConf.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the angle brackets
fixed |
we get
during reconstruction, needs to be investigated, where we access the string already. |
with iLCSoft/LCIO#19, iLCSoft/Clupatra#7 iLCSoft/MarlinReco#4 this should be running again. |
to address issue iLCSoft/LCIO#4