Support defaultNS from I18nextProvider props #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the default namespace to be specified as a prop of
`I18nextProvider`. Previously namespace came from i18n instance option,
and then from arguments to the `translate` HOC. This allows the
`translate` HOC to be invoked without an explicit namespace, and the
parent `I18nextProvider` can define an alternate default namespace. This
allows sharing `translate`d components without hard coding a defaultNS
at build time and without cloning multiple i18n instances to set
alternate namespaces.
e.g.
```
const Translated = translate()(Elem);
<I18nextProvider defaultNS="namespaceOne">
<Translated />
</I18nextProvider>
<I18nextProvider defaultNS="namespaceTwo">
<Translated />
</I18nextProvider>
```
|
Awesome...published in [email protected] |
|
Good addition - might be this is one of the last versions before breaking to use the new context API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the default namespace to be specified as a prop of
I18nextProvider. Previously namespace came from i18n instance option,and then from arguments to the
translateHOC. This allows thetranslateHOC to be invoked without an explicit namespace, and theparent
I18nextProvidercan define an alternate default namespace. Thisallows sharing
translated components without hard coding a defaultNSat build time and without cloning multiple i18n instances to set
alternate namespaces.
e.g.