-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: migrate to vitest #1708
test: migrate to vitest #1708
Conversation
6bd3eb5
to
78fc35e
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected], [email protected] |
I'm confused by code climate check: Do I need to implement the provided suggestions? |
no, these issues are there because of the filename change... you can ignore them |
Do you see the same errors locally? |
b33112f
to
f95d717
Compare
looks good now |
Yeah! Nice catch! |
ok, the coverage part seems to be the problem, like described here: vitest-dev/vitest#317 |
I’ll take a look later (having dinner) |
Great! Thank you for looking into this 🎉 |
Followup of #1707.
All tests now run with
vitest
.TransWithoutContext
file have been renamed withjsx
extension otherwisevitest
is not able to compile it correctly.Regular build should not be affect by this change.
TransWithoutContext
now use React functions to create JSX.ElementChecklist
npm run test