Fix linting errors, including pre-commit lint hook (#1659)

.codeclimate.yml

@@ -10,6 +10,7 @@ engines:
       - php
   eslint:
     enabled: true
+    channel: "eslint-8"
   fixme:
     enabled: true
 ratings:

.eslintrc

@@ -1,12 +1,9 @@
 {
   "extends": [
     "airbnb",
-    "prettier",
-    "prettier/react",
-    "plugin:testing-library/recommended",
-    "plugin:jest-dom/recommended"
+    "prettier"
   ],
-  "parser": "babel-eslint",
+  "parser": "@babel/eslint-parser",
   "parserOptions": {
     "ecmaVersion": 8,
     "ecmaFeatures": {
@@ -18,8 +15,7 @@
   "env": {
     "browser": true,
     "node": true,
-    "jquery": true,
-    "jest": true
+    "jquery": true
   },
   "rules": {
     "no-debugger": 0,
@@ -30,6 +26,10 @@
         "argsIgnorePattern": "res|next|^err"
       }
     ],
+    "prefer-arrow-callback": [
+      "error", {
+      "allowNamedFunctions": true
+    }],
     "prefer-const": [
       "error",
       {
@@ -77,6 +77,9 @@
         "extensions": [".js", ".jsx"]
       }
     ],
+    "react/no-unknown-property": ["error", {
+      "ignore": ["i18nIsDynamicList"]
+    }],
     "radix": 0,
     "no-shadow": [
       2,

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npx lint-staged

.prettierignore

@@ -0,0 +1,3 @@
+**/dist/**/*.js
+**/react-i18next.js
+**/react-i18next.min.js

example/locize/src/App.js

@@ -25,7 +25,7 @@ function MyComponent() {
 function Page() {
   const { t, i18n } = useTranslation();
 
-  const changeLanguage = lng => {
+  const changeLanguage = (lng) => {
     i18n.changeLanguage(lng);
   };
 

example/razzle-ssr/src/Home.js

@@ -4,7 +4,7 @@ import logo from './react.svg';
 import './Home.css';
 
 function Home() {
-  const [ t ] = useTranslation('translations');
+  const [t] = useTranslation('translations');
 
   return (
     <div className="Home">

example/razzle-ssr/src/index.js

@@ -2,7 +2,7 @@ import express from 'express';
 import app from './server';
 
 if (module.hot) {
-  module.hot.accept('./server', function() {
+  module.hot.accept('./server', function () {
     console.log('🔁  HMR Reloading `./server`...');
   });
   console.info('✅  Server-side HMR Enabled!');
@@ -12,7 +12,7 @@ const port = process.env.PORT || 3000;
 
 export default express()
   .use((req, res) => app.handle(req, res))
-  .listen(port, function(err) {
+  .listen(port, function (err) {
     if (err) {
       console.error(err);
       return;

example/react-icu/src/index.js

@@ -10,7 +10,7 @@ ReactDOM.render(
   <React.StrictMode>
     <App />
   </React.StrictMode>,
-  document.getElementById('root')
+  document.getElementById('root'),
 );
 
 // If you want your app to work offline and load faster, you can change

example/react-icu/src/serviceWorker.js

@@ -15,9 +15,7 @@ const isLocalhost = Boolean(
     // [::1] is the IPv6 localhost address.
     window.location.hostname === '[::1]' ||
     // 127.0.0.0/8 are considered localhost for IPv4.
-    window.location.hostname.match(
-      /^127(?:\.(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}$/
-    )
+    window.location.hostname.match(/^127(?:\.(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}$/),
 );
 
 export function register(config) {
@@ -43,7 +41,7 @@ export function register(config) {
         navigator.serviceWorker.ready.then(() => {
           console.log(
             'This web app is being served cache-first by a service ' +
-              'worker. To learn more, visit https://bit.ly/CRA-PWA'
+              'worker. To learn more, visit https://bit.ly/CRA-PWA',
           );
         });
       } else {
@@ -57,7 +55,7 @@ export function register(config) {
 function registerValidSW(swUrl, config) {
   navigator.serviceWorker
     .register(swUrl)
-    .then(registration => {
+    .then((registration) => {
       registration.onupdatefound = () => {
         const installingWorker = registration.installing;
         if (installingWorker == null) {
@@ -71,7 +69,7 @@ function registerValidSW(swUrl, config) {
               // content until all client tabs are closed.
               console.log(
                 'New content is available and will be used when all ' +
-                  'tabs for this page are closed. See https://bit.ly/CRA-PWA.'
+                  'tabs for this page are closed. See https://bit.ly/CRA-PWA.',
               );
 
               // Execute callback
@@ -93,7 +91,7 @@ function registerValidSW(swUrl, config) {
         };
       };
     })
-    .catch(error => {
+    .catch((error) => {
       console.error('Error during service worker registration:', error);
     });
 }
@@ -103,15 +101,15 @@ function checkValidServiceWorker(swUrl, config) {
   fetch(swUrl, {
     headers: { 'Service-Worker': 'script' },
   })
-    .then(response => {
+    .then((response) => {
       // Ensure service worker exists, and that we really are getting a JS file.
       const contentType = response.headers.get('content-type');
       if (
         response.status === 404 ||
         (contentType != null && contentType.indexOf('javascript') === -1)
       ) {
         // No service worker found. Probably a different app. Reload the page.
-        navigator.serviceWorker.ready.then(registration => {
+        navigator.serviceWorker.ready.then((registration) => {
           registration.unregister().then(() => {
             window.location.reload();
           });
@@ -122,19 +120,17 @@ function checkValidServiceWorker(swUrl, config) {
       }
     })
     .catch(() => {
-      console.log(
-        'No internet connection found. App is running in offline mode.'
-      );
+      console.log('No internet connection found. App is running in offline mode.');
     });
 }
 
 export function unregister() {
   if ('serviceWorker' in navigator) {
     navigator.serviceWorker.ready
-      .then(registration => {
+      .then((registration) => {
         registration.unregister();
       })
-      .catch(error => {
+      .catch((error) => {
         console.error(error.message);
       });
   }

example/react-native/App.js

@@ -6,7 +6,7 @@ import { initReactI18next, useTranslation } from 'react-i18next';
 const languageDetector = {
   type: 'languageDetector',
   async: true,
-  detect: cb => cb('en'),
+  detect: (cb) => cb('en'),
   init: () => {},
   cacheUserLanguage: () => {},
 };

example/react-native/app.json

@@ -1,4 +1,4 @@
 {
   "name": "Example",
   "displayName": "Example"
-}
+}

example/react-native/index.js

@@ -2,8 +2,8 @@
  * @format
  */
 
-import {AppRegistry} from 'react-native';
+import { AppRegistry } from 'react-native';
 import App from './App';
-import {name as appName} from './app.json';
+import { name as appName } from './app.json';
 
 AppRegistry.registerComponent(appName, () => App);

example/react-native/ios/Example/Images.xcassets/AppIcon.appiconset/Contents.json

@@ -1,38 +1,38 @@
 {
-  "images" : [
+  "images": [
     {
-      "idiom" : "iphone",
-      "size" : "29x29",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "29x29",
+      "scale": "2x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "29x29",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "29x29",
+      "scale": "3x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "40x40",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "40x40",
+      "scale": "2x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "40x40",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "40x40",
+      "scale": "3x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "60x60",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "60x60",
+      "scale": "2x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "60x60",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "60x60",
+      "scale": "3x"
     }
   ],
-  "info" : {
-    "version" : 1,
-    "author" : "xcode"
+  "info": {
+    "version": 1,
+    "author": "xcode"
   }
-}
+}

example/react-native/ios/Example/Images.xcassets/Contents.json

@@ -1,6 +1,6 @@
 {
-  "info" : {
-    "version" : 1,
-    "author" : "xcode"
+  "info": {
+    "version": 1,
+    "author": "xcode"
   }
 }

example/react-typescript/simple-multi-namespaces/src/components/Comp1.tsx

@@ -1,7 +1,7 @@
-import { useTranslation } from "react-i18next";
+import { useTranslation } from 'react-i18next';
 
 function Comp1() {
-  const {t} = useTranslation();
+  const { t } = useTranslation();
 
   return (
     <div className="App">
@@ -12,4 +12,4 @@ function Comp1() {
   );
 }
 
-export default Comp1;
+export default Comp1;

example/react-typescript/simple-multi-namespaces/src/components/Comp2.tsx

@@ -1,7 +1,7 @@
-import { useTranslation } from "react-i18next";
+import { useTranslation } from 'react-i18next';
 
 function Comp2() {
-  const {t} = useTranslation('ns2');
+  const { t } = useTranslation('ns2');
 
   return (
     <div className="App">
@@ -11,4 +11,4 @@ function Comp2() {
   );
 }
 
-export default Comp2;
+export default Comp2;

example/react-typescript/simple-multi-namespaces/src/i18n/en/ns1.json

@@ -4,4 +4,4 @@
     "part1": "This is a simple example.",
     "part2": "😉"
   }
-}
+}

example/react-typescript/simple-multi-namespaces/src/i18n/en/ns2.json

@@ -3,4 +3,4 @@
     "part1": "In order to infer the appropriate type for t function, you should use type augmentation to override the Resources type.",
     "part2": "Check out the @types/i18next to see an example."
   }
-}
+}

example/react-typescript/simple-multi-namespaces/src/index.tsx

@@ -3,11 +3,9 @@ import ReactDOM from 'react-dom/client';
 import './index.css';
 import App from './App';
 
-const root = ReactDOM.createRoot(
-  document.getElementById('root') as HTMLElement
-);
+const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
 root.render(
   <React.StrictMode>
     <App />
-  </React.StrictMode>
-);
+  </React.StrictMode>,
+);

example/react-typescript/simple-multi-namespaces/tsconfig.json

@@ -1,11 +1,7 @@
 {
   "compilerOptions": {
     "target": "es5",
-    "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
-    ],
+    "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
     "esModuleInterop": true,
@@ -20,7 +16,5 @@
     "noEmit": true,
     "jsx": "react-jsx"
   },
-  "include": [
-    "src"
-  ]
+  "include": ["src"]
 }

example/react-typescript/simple/src/index.tsx

@@ -3,11 +3,9 @@ import ReactDOM from 'react-dom/client';
 import './index.css';
 import App from './App';
 
-const root = ReactDOM.createRoot(
-  document.getElementById('root') as HTMLElement
-);
+const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
 root.render(
   <React.StrictMode>
     <App />
-  </React.StrictMode>
-);
+  </React.StrictMode>,
+);