Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explicit the need for getInitialProps for stateless app #646

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

eric-burel
Copy link
Contributor

It's a trap for new users. It is not immediate in Next official doc for custom app that we need to add getInitialProps for i18n, all the more that it disable automatic static optimization (it frightens beginners to uncomment the code :) )

It's a trap for new users. It is not immediate [in Next official doc for custom app](https://nextjs.org/docs/advanced-features/custom-app) that we need to add `getInitialProps` for i18n, all the more that it disable automatic static optimization (it frightens beginners to uncomment the code :) )
@isaachinman
Copy link
Contributor

Please add a semantic title. Otherwise looks good - thanks!

@eric-burel eric-burel changed the title Explicit the need for getInitialProps for stateless app docs: explicit the need for getInitialProps for stateless app Mar 6, 2020
@eric-burel
Copy link
Contributor Author

Done, thank you

@isaachinman isaachinman merged commit 881a3cc into i18next:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants