fix: Fix types for appWithTranslation #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated appWithTranslation generic type to fit what is sent in by the consumers of the library. Marks _nextI18Next in SSRConfig as possibly null, which it may be in the case of not calling serverSideTranslations in the page. Added a test for the updated type in the related testfile. Removed a few redundant null checks.
|
will be published with the next major -> #1966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the appWithTranslation generic type to fit what is sent in by the consumers of the library.
It also updates _nextI18Next in SSRConfig to be nullable, which it may be in the case of not calling serverSideTranslations in the page.
The inverse, which is how it is today, would mean that appWithTranslation always would get a _nextI18next prop, which is not guaranteed, as indicated by the various null checks and errors thrown.
This fixes #1944
Checklist
npm run test