fix: Respect configOverride.resources (#1707)

* fix: resources of configOverride doesn't work * fix: Respect configOverride.resources Co-authored-by: Md. Rubayet Hossain <[email protected]>
i18next · Feb 23, 2022 · 8d13429 · 8d13429
1 parent 8999125
commit 8d13429
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/src/appWithTranslation.client.test.tsx b/src/appWithTranslation.client.test.tsx
@@ -98,6 +98,34 @@ describe('appWithTranslation', () => {
     expect(args[0].i18n.options.configOverride).toBe('custom-value')
   })
 
+  it('allows passing configOverride.resources', () => {
+    const DummyAppConfigOverride = appWithTranslation(() => (
+      <div>Hello world</div>
+    ), {
+      i18n: {
+        defaultLocale: 'en',
+        locales: ['en', 'de'],
+      },
+      resources: {
+        xyz: {
+          custom: 'resources',
+        },
+      },
+    } as any)
+    render(
+      <DummyAppConfigOverride
+        {...createProps()}
+      />
+    )
+    const [args] = (I18nextProvider as jest.Mock).mock.calls
+
+    expect(args[0].i18n.options.resources).toMatchObject({
+      xyz: {
+        custom: 'resources',
+      },
+    })
+  })
+
   it('throws an error if userConfig and configOverride are both missing', () => {
     const DummyAppConfigOverride = appWithTranslation(() => (
       <div>Hello world</div>

diff --git a/src/appWithTranslation.tsx b/src/appWithTranslation.tsx
@@ -33,6 +33,8 @@ export const appWithTranslation = <Props extends AppProps = AppProps>(
 
       let { userConfig } = _nextI18Next
       const { initialI18nStore } = _nextI18Next
+      const resources =
+        configOverride?.resources ? configOverride.resources : initialI18nStore
 
       if (userConfig === null && configOverride === null) {
         throw new Error('appWithTranslation was called without a next-i18next config')
@@ -52,7 +54,7 @@ export const appWithTranslation = <Props extends AppProps = AppProps>(
           lng: locale,
         }),
         lng: locale,
-        resources: initialI18nStore,
+        resources,
       }).i18n
 
       globalI18n = instance