Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: using an external filter module from the command line #82

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Fix: using an external filter module from the command line #82

merged 1 commit into from
Mar 7, 2019

Conversation

jstarpl
Copy link
Contributor

@jstarpl jstarpl commented Mar 7, 2019

This patch fixes the command line -f option. Currently it doesn't work, reporting could not find module.

require uses a different CWD than fs operations. Therefore, existsSync will return true, but require will not be able to find the filter module. This patch uses an absolute file path for require, resolving this issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.297% when pulling 68087db on jstarpl:fix/argvFilter into 5e39eff on i18next:master.

@perrin4869 perrin4869 merged commit ca6f399 into i18next:master Mar 7, 2019
@perrin4869
Copy link
Contributor

Thanks! Will release soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstarpl @coveralls @perrin4869