Fix scratchpad #121
Merged
Fix scratchpad #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelKeizoStahl
force-pushed
the
fix-scratchpad
branch
from
9e3a604 to
7bf1218
Compare
|
This is now just the bug fix, the "feature" will be put on a feature request and can be discussed there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118
The problem is with the functionality of smart focusing.
It tries to not switch focus to a scratchpad, but instead of seeing if the window is currently a scratchpad, it checks if it was when it was focused.
I repaired this.
Now, if smart focusing is enabled, it will reopen any windows closed by a scratchpad's
excluderule once said scratchpad is closed.I believe this extra functionality makes sense for smart focusing, but of course it is up for discussion.