Skip to content

Commit

Permalink
[incubator/jaeger] Add basePath option for Jaeger. Based on helm#7490.
Browse files Browse the repository at this point in the history
Signed-off-by: Francois JACQUES <[email protected]>
  • Loading branch information
hypnoce committed Jan 5, 2019
1 parent 846b589 commit a3d7237
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion incubator/jaeger/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 1.8.2
description: A Jaeger Helm chart for Kubernetes
name: jaeger
version: 0.8.0
version: 0.8.1
keywords:
- jaeger
- opentracing
Expand Down
1 change: 1 addition & 0 deletions incubator/jaeger/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ The following table lists the configurable parameters of the Jaeger chart and th
| `query.service.queryPort` | External accessible port | 80 |
| `query.service.targetPort` | Internal Query UI port | 16686 |
| `query.service.type` | Service type | ClusterIP |
| `query.basePath` | Base path of Query UI | / |
| `schema.annotations` | Annotations for the schema job | nil |
| `schema.image` | Image to setup cassandra schema | jaegertracing/jaeger-cassandra-schema |
| `schema.mode` | Schema mode (prod or test) | prod |
Expand Down
1 change: 1 addition & 0 deletions incubator/jaeger/templates/common-cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ data:
span-storage.type: {{ .Values.storage.type | quote }}
query.health-check-http-port: {{ .Values.query.healthCheckPort | quote }}
query.port: {{ .Values.query.service.targetPort | quote }}
query.base-path: {{ .Values.query.basePath | quote }}
# Not implemented
# cassandra.archive.connections-per-host:
# cassandra.archive.keyspace:
Expand Down
5 changes: 5 additions & 0 deletions incubator/jaeger/templates/query-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ spec:
configMapKeyRef:
name: {{ template "jaeger.fullname" . }}
key: query.health-check-http-port
- name: QUERY_BASE_PATH
valueFrom:
configMapKeyRef:
name: {{ template "jaeger.fullname" . }}
key: query.base-path
ports:
- containerPort: {{ .Values.query.service.targetPort }}
protocol: TCP
Expand Down
1 change: 1 addition & 0 deletions incubator/jaeger/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ query:
dnsPolicy: ClusterFirst
cmdlineParams: {}
healthCheckPort: 16687
basePath: /
replicaCount: 1
service:
annotations: {}
Expand Down

0 comments on commit a3d7237

Please sign in to comment.