Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8-spellcheck issues fix #23

Merged
merged 8 commits into from
Apr 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics --exclude=.git,__pycache__,docs/source/conf.py,old,build,dist,venv,test/resources,.eggs,review.egg-info,.pytest_cache,node_modules
# TODO: change max-complexity into 10 after refactoring
flake8 . --count --max-complexity=11 --max-line-length=120 --max-doc-length=120 --ignore=R504,A003,E800,SC200,SC100,E402,W503,WPS,H601 --statistics --exclude=.git,__pycache__,docs/source/conf.py,old,build,dist,venv,test/resources,.eggs,review.egg-info,.pytest_cache,node_modules
flake8 . --count --max-complexity=11 --max-line-length=120 --max-doc-length=120 --ignore=R504,A003,E800,E402,W503,WPS,H601 --statistics --exclude=.git,__pycache__,docs/source/conf.py,old,build,dist,venv,test/resources,.eggs,review.egg-info,.pytest_cache,node_modules
- name: Set up Eslint
run: |
npm install eslint --save-dev
Expand Down
2 changes: 1 addition & 1 deletion src/python/review/quality/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def quality_type(self) -> QualityType:
def next_quality_type(self) -> QualityType:
return min(map(lambda rule: rule.next_level_type, self.rules), default=QualityType.EXCELLENT)

# TODO@nbirillo: why rule.quality_type == quality_type for next level????
# TODO: why rule.quality_type == quality_type for next level????
@property
def next_level_requirements(self) -> List[Rule]:
quality_type = self.quality_type
Expand Down
20 changes: 18 additions & 2 deletions whitelist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,28 @@ utils
param
params
changelog
multiline
sqrt
WPS
OOP
mccabe
mcs
dicts
misrefactored
src
textwrap
dedent
maintainabilities
parsers
fs
KTS
nl
splitext
dirname
# Springlint issues
cbo
dit
lcom
noc
nom
wmc
multiline
sqrt