Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for AssemblyScript SDK Transform #659

Merged
merged 22 commits into from
Dec 23, 2024

Conversation

JairusSW
Copy link
Member

@JairusSW JairusSW commented Dec 19, 2024

Implement tests for AssemblyScript SDK transform

I implemented a basic test suite using node's builtin testing library which provided basic testing for the ASC Transform.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable

@JairusSW JairusSW requested a review from a team as a code owner December 19, 2024 19:05
@JairusSW JairusSW enabled auto-merge (squash) December 19, 2024 19:06
@JairusSW JairusSW changed the title Jairus/hyp 960 unit tests for plugin transform Jairus/implement-assemblyscript-sdk-tests Dec 19, 2024
@JairusSW JairusSW changed the title Jairus/implement-assemblyscript-sdk-tests Jairus/add-assemblyscript-sdk-transform-tests Dec 19, 2024
@JairusSW JairusSW assigned JairusSW and unassigned JairusSW Dec 20, 2024
@mattjohnsonpint mattjohnsonpint changed the title Jairus/add-assemblyscript-sdk-transform-tests test: add assemblyscript transform tests Dec 22, 2024
@mattjohnsonpint mattjohnsonpint changed the title test: add assemblyscript transform tests test: add tests for AssemblyScript SDK Transform Dec 22, 2024
Copy link
Member

@mattjohnsonpint mattjohnsonpint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write these in typescript? Thanks.

Co-authored-by: Matt Johnson-Pint <[email protected]>
@JairusSW
Copy link
Member Author

@mattjohnsonpint yeah, I can do that
Just have to tweak the tsconfig a bit

@JairusSW
Copy link
Member Author

@mattjohnsonpint I didn't end up compiling the tests to js with tsc, instead I added node's new --experimental-strip-types flag so it can execute the TypeScript files directly
Its experimental, so if you want, I can always switch it back to tsc, just lmk

@mattjohnsonpint
Copy link
Member

For tests, the flag is fine as long as it works. We can always replace it with tsc later if fails on anything.

Please add our standard copyright header to the newly added .ts files, and then I'll approve. Thanks.

@JairusSW JairusSW merged commit e5394e3 into main Dec 23, 2024
34 checks passed
@JairusSW JairusSW deleted the jairus/hyp-960-unit-tests-for-plugin-transform branch December 23, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants