Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vector package should return generic type in computations #628

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Nov 27, 2024

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo staged and linked here

Instructions

  • The PR title should follow the Conventional Commits syntax, leading with fix:, feat:, chore:, ci:, etc.
  • The description should briefly explain what the PR is about. In the case of a bugfix, describe or link to the bug.
  • In the checklist section, check the boxes in that are applicable, using [x] syntax.
    • If not applicable, remove the entire line. Only leave the box unchecked if you intend to come back and check the box later.
  • Delete the Instructions line and everything below it, to indicate you have read and are following these instructions. 🙂

Thank you for your contribution to the Modus project!

@jairad26 jairad26 requested a review from a team as a code owner November 27, 2024 23:13
@jairad26 jairad26 changed the title vector package should return generic type in computations fix: vector package should return generic type in computations Nov 27, 2024
@jairad26 jairad26 enabled auto-merge (squash) November 27, 2024 23:24
@jairad26 jairad26 merged commit 56f4bfe into main Nov 28, 2024
85 checks passed
@jairad26 jairad26 deleted the jai/hyp-2695-modus-vector-package-returns-wrong-types branch November 28, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants