Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use git commit with double quotes for Windows #612

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: use git commit with double quotes for Windows #612

merged 2 commits into from
Nov 25, 2024

Conversation

octref
Copy link
Member

@octref octref commented Nov 25, 2024

Description

git commit -m 'commit' might fail on Windows.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo staged and linked here

@octref octref requested a review from a team as a code owner November 25, 2024 18:10
@octref octref merged commit a60679f into main Nov 25, 2024
6 checks passed
@octref octref deleted the pine/fix-windows-git-commit branch November 25, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octref @mattjohnsonpint