Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI errors #517

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Fix CLI errors #517

merged 3 commits into from
Oct 28, 2024

Conversation

mattjohnsonpint
Copy link
Member

Fix unhandled ExitPromptError: User force closed the prompt with 0 null errors from the CLI

  • All prompts are async and should have await keywords used. (root cause)
  • Any CLI command that uses prompts should have a single try/catch for the CLI command that will handle the user aborting the prompt (ie., pressing ctrl-c instead of y or n).

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner October 28, 2024 16:15
@mattjohnsonpint mattjohnsonpint changed the title Mjp/hyp 2510 cli errors Fix CLI errors Oct 28, 2024
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) October 28, 2024 16:15
@mattjohnsonpint mattjohnsonpint merged commit dd497c0 into main Oct 28, 2024
4 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2510-cli-errors branch October 28, 2024 16:19
@mattjohnsonpint mattjohnsonpint mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanfoxtyler ryanfoxtyler ryanfoxtyler approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjohnsonpint @ryanfoxtyler