add jwks endpoint key support to auth #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjohnsonpint
approved these changes
Oct 26, 2024
jairad26
deleted the
jai/hyp-2498-add-jwks-endpoint-support-to-auth-in-modus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for JWKS endpoints for authentication. this is supplied via
MODUS_JWKS_ENDPOINTSenv variable. This also refactors the auth to separate pem and jwks, since jwks must be refreshed to maintain up-to-date keys. The env varMODUS_JWKS_REFRESH_MINUTESis used to give users the ability to override in the futureChecklist
CHANGELOG.mdfile describing and linking to this PRThank you for your contribution to the Modus project!