Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app path required #457

Merged
merged 6 commits into from
Oct 12, 2024

Conversation

mattjohnsonpint
Copy link
Member

Description

  • -storagePath has been replaced with -appPath and is now REQUIRED
    • The default path has been removed. That means we will no longer be running the runtime pointed at a common directory such as ~/.hypermode, but instead the runtime will be invoked for a specific Modus app. The -appPath should point at the build directory, or wherever the .wasm file will be found.
  • Updated the VS Code launch settings, such that while debugging the Modus runtime, you can either enter a path to an app to run, or you can select one of the examples that's already in the repo.
    • For now, you still need to build the example independently, but the runtime will watch the build folder associated with the selected example.
  • Renamed one of the examples to align the folder names across languages.

Checklist

  • Code compiles correctly and linting passes locally
  • Tests for new functionality and regression tests for bug fixes added
  • Documentation added or updated
  • Entry added to the CHANGELOG.md file describing and linking to this PR

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner October 12, 2024 01:22
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) October 12, 2024 01:24
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) October 12, 2024 01:25
@mattjohnsonpint mattjohnsonpint merged commit 06a47bb into main Oct 12, 2024
80 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2323-runtime-instancing-storage-paths branch October 12, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants