Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove http timeout and add context timeout on collections #422

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Oct 4, 2024

No description provided.

@jairad26 jairad26 requested a review from a team as a code owner October 4, 2024 19:02
Copy link

linear bot commented Oct 4, 2024

HYP-1867 HTTP client timeout

Currently, we have all outbound HTTP calls hardcoded to a timeout of 10 seconds. This includes:

  • HTTP fetch host function
  • GraphQL client host function
  • Model invoke host function

The hardcoded timeout makes it impossible to fetch data from any source that takes longer than 10 seconds to respond.

We should consider whether there should be a timeout by default at all, or if the default should be no timeout. We should also consider if the timeout value should be configurable in user code or in the manifest.

In all cases, we already cancel any request that is in-progress if the incoming function call is aborted, so there's not much risk in extending or removing the timeout.

@jairad26 jairad26 enabled auto-merge (squash) October 4, 2024 19:06
@jairad26 jairad26 merged commit bb1a044 into main Oct 4, 2024
43 checks passed
@jairad26 jairad26 deleted the jai/hyp-1867-http-client-timeout branch October 4, 2024 19:06
@mattjohnsonpint mattjohnsonpint added this to the v0.13.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants