Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): add paths to ignore #8791

Merged
merged 2 commits into from
May 2, 2023
Merged

chore(CI): add paths to ignore #8791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8126ad0
add paths to ignore
MichelDiz Apr 6, 2023
301708a
address Joshua's comments and more.
MichelDiz Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/ci-aqua-security-trivy-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: ci-aqua-security-trivy-tests
on:
push:
paths-ignore:
- '.vscode/CODEOWNERS'
- '.vscode/*.json'
- 'compose/**'
- 'contrib/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our canonical Dockerfile is located in contrib, this should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of Contrib says:

The contrib directory contains scripts, images, and other helpful things which are not part of the core dgraph distribution. Please note that they could be out of date, since they do not receive the same attention as the rest of the repository.

The objective of the tests are related to the core code or helpful things we use time to time?

The thing is. If your PR change some code AND change something in contrib. The CI will be triggered.

Now, let's say I wanna update something in /contrib/systemd/ or /contrib/jepsen. Are the CI covering those? So why run the CI at all?

If you need to update some dockerfile or docker compose. We will have an option to trigger manually if needed. But it is something we can think more about. Maybe have a granular control here instead ignoring the whole contrib file.

- 'dgraphtest/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed - if we make a change to our test suite, we want to see if the tests pass or fail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

- 'licenses/**'
- 'paper/**'
- 'RFC/**'
- 'static/**'
- 't/**'
- 'telemetry/**'
- 'wiki/**'
- '**.dockerignore'
- '**.gitignore'
- '**/**.md'
- '**/**.png'
- '**/**.sh'
- '**/**.gif'
- '**/**.ini'
branches:
- main
- 'release/**'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/ci-dgraph-code-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: ci-dgraph-code-coverage
on:
push:
paths-ignore:
- '.vscode/CODEOWNERS'
- '.vscode/*.json'
- 'compose/**'
- 'contrib/**'
- 'dgraphtest/**'
- 'licenses/**'
- 'paper/**'
- 'RFC/**'
- 'static/**'
- 't/**'
- 'telemetry/**'
- 'wiki/**'
- '**.dockerignore'
- '**.gitignore'
- '**/**.md'
- '**/**.png'
- '**/**.sh'
- '**/**.gif'
- '**/**.ini'
branches:
- main
- 'release/**'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/ci-dgraph-ldbc-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: ci-dgraph-ldbc-tests
on:
push:
paths-ignore:
- '.vscode/CODEOWNERS'
- '.vscode/*.json'
- 'compose/**'
- 'contrib/**'
- 'dgraphtest/**'
- 'licenses/**'
- 'paper/**'
- 'RFC/**'
- 'static/**'
- 't/**'
- 'telemetry/**'
- 'wiki/**'
- '**.dockerignore'
- '**.gitignore'
- '**/**.md'
- '**/**.png'
- '**/**.sh'
- '**/**.gif'
- '**/**.ini'
branches:
- main
- 'release/**'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/ci-dgraph-load-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: ci-dgraph-load-tests
on:
push:
paths-ignore:
- '.vscode/CODEOWNERS'
- '.vscode/*.json'
- 'compose/**'
- 'contrib/**'
- 'dgraphtest/**'
- 'licenses/**'
- 'paper/**'
- 'RFC/**'
- 'static/**'
- 't/**'
- 'telemetry/**'
- 'wiki/**'
- '**.dockerignore'
- '**.gitignore'
- '**/**.md'
- '**/**.png'
- '**/**.sh'
- '**/**.gif'
- '**/**.ini'
branches:
- main
- 'release/**'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/ci-dgraph-tests-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: ci-dgraph-tests-arm64
on:
push:
paths-ignore:
- '.vscode/CODEOWNERS'
- '.vscode/*.json'
- 'compose/**'
- 'contrib/**'
- 'dgraphtest/**'
- 'licenses/**'
- 'paper/**'
- 'RFC/**'
- 'static/**'
- 't/**'
- 'telemetry/**'
- 'wiki/**'
- '**.dockerignore'
- '**.gitignore'
- '**/**.md'
- '**/**.png'
- '**/**.sh'
- '**/**.gif'
- '**/**.ini'
branches:
- main
- 'release/**'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/ci-dgraph-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: ci-dgraph-tests
on:
push:
paths-ignore:
- '.vscode/CODEOWNERS'
- '.vscode/*.json'
- 'compose/**'
- 'contrib/**'
- 'dgraphtest/**'
- 'licenses/**'
- 'paper/**'
- 'RFC/**'
- 'static/**'
- 't/**'
- 'telemetry/**'
- 'wiki/**'
- '**.dockerignore'
- '**.gitignore'
- '**/**.md'
- '**/**.png'
- '**/**.sh'
- '**/**.gif'
- '**/**.ini'
branches:
- main
- 'release/**'
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/ci-golang-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: ci-golang-lint
on:
push:
paths-ignore:
- '.vscode/CODEOWNERS'
- '.vscode/*.json'
- 'compose/**'
- 'contrib/**'
- 'dgraphtest/**'
- 'licenses/**'
- 'paper/**'
- 'RFC/**'
- 'static/**'
- 't/**'
- 'telemetry/**'
- 'wiki/**'
- '**.dockerignore'
- '**.gitignore'
- '**/**.md'
- '**/**.png'
- '**/**.sh'
- '**/**.gif'
- '**/**.ini'
branches:
- main
- 'release/**'
Expand Down