Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove arch from ldflag #8546

Merged
merged 1 commit into from
Dec 16, 2022
Merged

chore(ci): remove arch from ldflag #8546

merged 1 commit into from
Dec 16, 2022

Conversation

joshua-goldstein
Copy link
Contributor

Dgraph version ldflag should not have arch (only version number). We update the Makefile to not add this in the ldflags build arguments.

Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@skrdgraph skrdgraph merged commit f065f6a into main Dec 16, 2022
@skrdgraph skrdgraph deleted the joshua/quick-fix branch December 16, 2022 23:00
@skrdgraph skrdgraph restored the joshua/quick-fix branch December 16, 2022 23:00
@skrdgraph skrdgraph deleted the joshua/quick-fix branch December 16, 2022 23:00
@skrdgraph skrdgraph restored the joshua/quick-fix branch December 16, 2022 23:01
joshua-goldstein added a commit that referenced this pull request Dec 16, 2022
Dgraph version ldflag should not have arch (only version number). We
update the Makefile to not add this in the ldflags build arguments.

(cherry picked from commit f065f6a)
skrdgraph pushed a commit that referenced this pull request Dec 16, 2022
Dgraph version ldflag should not have arch (only version number). We
update the Makefile to not add this in the ldflags build arguments.

(cherry picked from commit f065f6a)
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 64.054% when pulling d9a9cda on joshua/quick-fix into 7b18a6b on main.

@joshua-goldstein joshua-goldstein deleted the joshua/quick-fix branch May 17, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants