Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cicd): run on draft PRs #8440

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix(cicd): run on draft PRs #8440

merged 1 commit into from
Nov 17, 2022

Conversation

skrdgraph
Copy link
Contributor

Problem

draft ci runs need to be enabled because we are closing in for release

Solution

fix the ci config to enable runs on draft PRs

@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Nov 17, 2022
@skrdgraph
Copy link
Contributor Author

cc: @anurags92 - you will have to uncomment this post release* (please add a task to uncomment in your name)

@skrdgraph skrdgraph marked this pull request as ready for review November 17, 2022 21:25
meghalims
meghalims approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@skrdgraph skrdgraph merged commit bf64870 into main Nov 17, 2022
@skrdgraph skrdgraph deleted the skrdgraph/cicd_run_on_draft_pr branch November 17, 2022 21:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.182% when pulling 4aa22b1 on skrdgraph/cicd_run_on_draft_pr into 2329f1b on main.

@MichelDiz MichelDiz added the dgraph Issue or PR created by an internal Dgraph contributor. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meghalims meghalims meghalims approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@gcxml gcxml Awaiting requested review from gcxml

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/integrations Related to integrations with other projects. dgraph Issue or PR created by an internal Dgraph contributor.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skrdgraph @coveralls @meghalims @MichelDiz