-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): add draft check in the workflow yaml #8396
Conversation
Referencing this issue https://github.com/dgraph-io/projects/issues/14 |
@anurags92 as I was seeing this, an edge case came to my mind.
I am not sure if this PR actually forces a run after a transition. It would probably trigger the run when a commit is made on a ready-for-review PR. I am not sure how this works. Leaving my thoughts from observation (I need to read the docs for better understanding) |
See my commit b4feeca which handles exactly this. |
@skrdgraph
I have added |
Problem
Currently the tests runs on draft PR as well which is waste of resources.
Solution
Add a
if: ! github.event.pull_request.draft
check to prevent GH runs on draft PRs. Reference: https://stackoverflow.com/questions/68349031/only-run-actions-on-non-draft-pull-request