-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chore): modify year in copyright #8385
Conversation
Shreyasi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me now. @skrdgraph please review.
@@ -117,7 +117,7 @@ func TestBackupMinio(t *testing.T) { | |||
dirSetup(t) | |||
|
|||
// Send backup request. | |||
// TODO: minio backup request fails when the environment is not ready, | |||
// TODO: minio backup request fails when the environment is not ready, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SashaDgraph I guess this was missed in your checks, but it's okay (an extra space was cleaned up ~ possibly by your IDE)
👍 This PR looks good @SashaDgraph. I did a full review @dshekhar95 - could you review this as well? This PR is touching 400+files, I did catch one small unrelated change - where I have left a comment. The best way to check the diff's is from your local IDE. We will wait for your review & then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for reference, only file i saw with 2 changes was x/init.go
looks fine to me
Problem
copyright version out of sync
Solution
change to 2022