Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci) fixing the file permission issue for CI runner #8311

Merged
merged 5 commits into from
Sep 17, 2022
Merged

fix(ci) fixing the file permission issue for CI runner #8311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0889155
undo changes to dgraph tests
skrdgraph Sep 17, 2022
573740f
undo changes to load tests
skrdgraph Sep 17, 2022
ac1ee64
fixing the runner user, to handle cruft cleanup issue
skrdgraph Sep 17, 2022
c2619e3
fix test cruft issue
skrdgraph Sep 17, 2022
9785523
fix test cleanup
skrdgraph Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/ci-dgraph-load-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ on:
schedule:
- cron: "*/30 * * * *"
jobs:
#TODO: WE NEED TO REMOVE THIS CLEANUP, and handle it more elegantly, it makes us incompatible with gh-hosted-runners
cleanup:
runs-on: self-hosted
container:
image: ubuntu:latest
steps:
- name: Cleaning up the $GITHUB_WORKSPACE as root from a Docker image
run: find /__w/${{ github.event.repository.name }}/${{ github.event.repository.name }}/. -name . -o -prune -exec rm -rf -- {} + || true
Comment on lines -12 to -19
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshua-goldstein & @dshekhar95 this won't be needed anymore because of the fix in the infrastructure layer

dgraph-load-tests:
runs-on: self-hosted
steps:
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/ci-dgraph-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ on:
schedule:
- cron: "*/30 * * * *"
jobs:
#TODO: WE NEED TO REMOVE THIS CLEANUP, and handle it more elegantly, it makes us incompatible with gh-hosted-runners
cleanup:
runs-on: self-hosted
container:
image: ubuntu:latest
steps:
- name: Cleaning up the $GITHUB_WORKSPACE as root from a Docker image
run: find /__w/${{ github.event.repository.name }}/${{ github.event.repository.name }}/. -name . -o -prune -exec rm -rf -- {} + || true
Comment on lines -12 to -19
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshua-goldstein & @dshekhar95 this won't be needed anymore because of the fix in the infrastructure layer

dgraph-tests:
runs-on: self-hosted
steps:
Expand Down
1 change: 1 addition & 0 deletions contrib/gh-runner/gh-runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ curl -o actions-runner-linux-x64-2.296.2.tar.gz -L https://github.com/actions/ru
echo "34a8f34956cdacd2156d4c658cce8dd54c5aef316a16bbbc95eb3ca4fd76429a actions-runner-linux-x64-2.296.2.tar.gz" | shasum -a 256 -c
tar xzf ./actions-runner-linux-x64-2.296.2.tar.gz
./config.sh --url https://github.com/dgraph-io/dgraph --token $TOKEN
sudo chown -R $USER:$USER /home/ubuntu/actions-runner/_work # fixes the test cruft cleanup issue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshua-goldstein @dshekhar95 this is the correct way to fix it at the infrastructure layer.

sudo ./svc.sh install
sudo ./svc.sh start
# Reboot Machine
Expand Down