Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ristretto): update dependency on ristretto #8295

Closed
wants to merge 1 commit into from

Conversation

joshua-goldstein
Copy link
Contributor

@joshua-goldstein joshua-goldstein commented Sep 15, 2022

Problem

Dgraph currently uses Ristretto v0.1.0. There are a few bug fixes and updates that have gone into the Ristretto master branch that are not in v0.1.0. However, we would prefer to be cautious and not pull in the latest version of Ristretto as significant refactoring took place. This PR introduces a new version of Ristretto which we tentatively call v0.1.1. Currently the go.mod uses a commit SHA which is messy, but once we are sure about the stability of this update we will make will make a tag on Ristretto and set the dependency on that.

We include in this PR:

Solution

Update dependency on Ristretto to a stable v0.1.1.

Remark

See new PR #8365

@coveralls
Copy link

coveralls commented Sep 15, 2022

Coverage Status

Coverage remained the same at 37.099% when pulling 5d89b20 on joshua/update-ristretto into 9b67017 on main.

Copy link
Contributor

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Josh,
As we discussed, we will take it in post 22.0.0 after we make a formal release of ristretto

@skrdgraph
Copy link
Contributor

@joshua-goldstein based on @meghalims's comment I am guessing we are going to punt on this one. If that is the case do you mind changing this to a draft?

@joshua-goldstein joshua-goldstein changed the title fix(ristretto): update dependency on ristretto fix(ristretto): update dependency on ristretto Sep 26, 2022
@joshua-goldstein joshua-goldstein marked this pull request as draft September 26, 2022 17:42
@joshua-goldstein joshua-goldstein deleted the joshua/update-ristretto branch May 17, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants