Skip to content

Commit

Permalink
chore(ci): fix breaking tests (#8413)
Browse files Browse the repository at this point in the history
## Problem

Since we added arm64 runners, they are being picked up by our workflows.
Tests are failing after about 1 minute with exec format error (due to
documented Badger/Ristretto issue).

For more info on runner labels [see
here.](https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow#using-default-labels-to-route-jobs)

## Solution

We modify workflows to only pickup amd runners. We also pin the Go
version.
  • Loading branch information
joshua-goldstein authored Nov 4, 2022
1 parent b760646 commit 5f5994a
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 8 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/ci-dgraph-load-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,18 @@ on:
jobs:
dgraph-load-tests:
if: github.event.pull_request.draft == false
runs-on: self-hosted
runs-on: [self-hosted, x64]
steps:
- uses: actions/checkout@v3
- name: Get Go Version
run: |
#!/bin/bash
GOVERSION=$({ [ -f .go-version ] && cat .go-version; })
echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.18
go-version: ${{ env.GOVERSION }}
- name: Set up Node
uses: actions/setup-node@v3
with:
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/ci-dgraph-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,18 @@ on:
jobs:
dgraph-tests:
if: github.event.pull_request.draft == false
runs-on: self-hosted
runs-on: [self-hosted, x64]
steps:
- uses: actions/checkout@v3
- name: Get Go Version
run: |
#!/bin/bash
GOVERSION=$({ [ -f .go-version ] && cat .go-version; })
echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.18
go-version: ${{ env.GOVERSION }}
- name: Set up Node
uses: actions/setup-node@v3
with:
Expand Down
16 changes: 12 additions & 4 deletions .github/workflows/ci-golang-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,23 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Get Go Version
run: |
#!/bin/bash
GOVERSION=$({ [ -f .go-version ] && cat .go-version; })
echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV
- name: Setup Go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GOVERSION }}
- name: golang-lint
env:
# prevent OOM
GOGC: 10
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.36
version: latest
only-new-issues: true
args: --timeout=10m
skip-go-installation: true

0 comments on commit 5f5994a

Please sign in to comment.