Skip to content

Commit

Permalink
fix(core): Fix deleteBelowTs rollup issue
Browse files Browse the repository at this point in the history
  • Loading branch information
harshil-goel committed Jan 30, 2025
1 parent c0789e2 commit 2dc1974
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion posting/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,10 @@ type pIterator struct {
}

func (it *pIterator) seek(l *List, afterUid, deleteBelowTs uint64) error {
if deleteBelowTs > 0 && deleteBelowTs <= l.minTs {
// Because we store rollup at commitTs + 1, it could happen that a transaction has a startTs = prev commitTs
// + 1. Within that transcation if there's a delete all, deleteBelowTs (=startT) would be equal to l.minTs
// (rollup timestamp, prev commitTs + 1). So it's allowed deleteBelowTs == l.minTs
if deleteBelowTs > 0 && deleteBelowTs < l.minTs {
return errors.Errorf("deleteBelowTs (%d) must be greater than the minTs in the list (%d)",
deleteBelowTs, l.minTs)
}
Expand Down

0 comments on commit 2dc1974

Please sign in to comment.