Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more token pool details #76

Merged
merged 3 commits into from
May 2, 2022
Merged

Add more token pool details #76

merged 3 commits into from
May 2, 2022

Conversation

awrichar
Copy link
Contributor

Allow looking up pools by ID, attempt to quantify pools that have data
support, and enrich some transaction_submitted events with a pool ID.

Will require a new SDK release with hyperledger/firefly-sdk-nodejs#27

Allow looking up pools by ID, attempt to quantify pools that have data
support, and enrich some transaction_submitted events with a pool ID.

Signed-off-by: Andrew Richardson <[email protected]>
Copy link
Contributor

@dechdev dechdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment regarding strings and enums.

server/src/controllers/websocket.ts Outdated Show resolved Hide resolved
dechdev added 2 commits May 2, 2022 10:23
Signed-off-by: David Echelberger <[email protected]>
Signed-off-by: David Echelberger <[email protected]>
@dechdev dechdev merged commit 1d881f9 into hyperledger:main May 2, 2022
@awrichar awrichar deleted the pool branch May 2, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants