Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more clarity to logs for event enrichment failures #71

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

matthew1001
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #71 (ee9f5cb) into main (dd7b14d) will decrease coverage by 0.14%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   97.38%   97.24%   -0.14%     
==========================================
  Files          23       23              
  Lines        1414     1417       +3     
==========================================
+ Hits         1377     1378       +1     
- Misses         27       28       +1     
- Partials       10       11       +1     
Impacted Files Coverage Δ
internal/ethereum/event_listener.go 98.88% <50.00%> (-1.12%) ⬇️
internal/ethereum/event_stream.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@awrichar awrichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I think you added a new code branch which may also need a new unit test to maintain coverage.

@peterbroadhurst peterbroadhurst merged commit 9512b8a into hyperledger:main Apr 27, 2023
@peterbroadhurst
Copy link
Contributor

@matthew1001 - I've merged this to include in the release. Would be great to re-instate the coverage as a follow-up on the next PR you do

@peterbroadhurst peterbroadhurst deleted the log-tidy-up branch April 27, 2023 22:12
@matthew1001
Copy link
Contributor Author

My bad, PR coming to fix coverage...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants