-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few data types in the config docs #36
Conversation
- update contributors URL Signed-off-by: Chris Bygrave <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chrisbygrave, this is great!
However... these types are actually built into Markdown from source, and the build checks what's checked in is matched with the latest generation.
You have to run make reference
before committing, otherwise the make
build fails showing you the mismatch.
So they need to be changed where the parameters are defined - which in this case is actually in some pre-reqs.
I've put in some pointers, and there's one that's confused me as to how we're getting the bug you point out.
Thanks for the pointers @peterbroadhurst! I hadn't spotted this was generated - I'll work through the pointers in a couple of follow-on PRs |
- cors headers, methods, and origins are string arrays - the float type was incorrectly specced as a boolean - hyperledger/firefly-evmconnect#36 Signed-off-by: Chris Bygrave <[email protected]>
- hyperledger/firefly-evmconnect#36 Signed-off-by: Chris Bygrave <[email protected]>
Signed-off-by: Chris Bygrave <[email protected]>
Ok, so:
Searching across hyperledger, I didn't find anywhere else using the |
ok - release up for common here, that'll need to go into the FFTM PR |
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1293 1291 -2
=========================================
- Hits 1293 1291 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'll update this one once accordingly we get the FFTM PR through |
https://github.com/hyperledger/firefly-transaction-manager/releases/tag/v1.1.1 ready to pull in here now @chrisbygrave |
Signed-off-by: Chris Bygrave <[email protected]>
Thanks @chrisbygrave for working this through all the layers 💪 |
fixed
is referenced in a few examples but wasn't included in the list of supported valuesSigned-off-by: Chris Bygrave [email protected]