Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few data types in the config docs #36

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

chrisbygrave
Copy link
Contributor

  • fix a few data types that aren't correct in config.md
  • update contributors URL - dead link to the (I believe) correct link
  • gas oracle modes - fixed is referenced in a few examples but wasn't included in the list of supported values

Signed-off-by: Chris Bygrave [email protected]

- update contributors URL

Signed-off-by: Chris Bygrave <[email protected]>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrisbygrave, this is great!
However... these types are actually built into Markdown from source, and the build checks what's checked in is matched with the latest generation.
You have to run make reference before committing, otherwise the make build fails showing you the mismatch.

So they need to be changed where the parameters are defined - which in this case is actually in some pre-reqs.
I've put in some pointers, and there's one that's confused me as to how we're getting the bug you point out.

config.md Outdated Show resolved Hide resolved
config.md Outdated Show resolved Hide resolved
config.md Show resolved Hide resolved
config.md Show resolved Hide resolved
config.md Show resolved Hide resolved
config.md Outdated Show resolved Hide resolved
config.md Outdated Show resolved Hide resolved
@chrisbygrave
Copy link
Contributor Author

Thanks for the pointers @peterbroadhurst! I hadn't spotted this was generated - I'll work through the pointers in a couple of follow-on PRs

chrisbygrave added a commit to chrisbygrave/firefly-common that referenced this pull request Oct 7, 2022
- cors headers, methods, and origins are string arrays
- the float type was incorrectly specced as a boolean

- hyperledger/firefly-evmconnect#36

Signed-off-by: Chris Bygrave <[email protected]>
chrisbygrave added a commit to chrisbygrave/firefly-transaction-manager that referenced this pull request Oct 7, 2022
Signed-off-by: Chris Bygrave <[email protected]>
@chrisbygrave
Copy link
Contributor Author

Ok, so:

Searching across hyperledger, I didn't find anywhere else using the FloatType other than firefly-transaction-manager, which uses it as the type for the event streams retry factor - another place we wanted to fix.

@peterbroadhurst
Copy link
Contributor

ok - release up for common here, that'll need to go into the FFTM PR

@codecov-commenter
Copy link

Codecov Report

Merging #36 (3e9b8bd) into main (4767448) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1293      1291    -2     
=========================================
- Hits          1293      1291    -2     
Impacted Files Coverage Δ
internal/ethereum/event_listener.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chrisbygrave
Copy link
Contributor Author

I'll update this one once accordingly we get the FFTM PR through

@peterbroadhurst
Copy link
Contributor

https://github.com/hyperledger/firefly-transaction-manager/releases/tag/v1.1.1 ready to pull in here now @chrisbygrave

Signed-off-by: Chris Bygrave <[email protected]>
@peterbroadhurst
Copy link
Contributor

Thanks @chrisbygrave for working this through all the layers 💪

@peterbroadhurst peterbroadhurst merged commit 87a5291 into hyperledger:main Oct 7, 2022
@chrisbygrave chrisbygrave deleted the config-readme branch October 10, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants