Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower default catchup page size #29

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Sep 2, 2022

Signed-off-by: Nicko Guyer [email protected]

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting the reason here I believe is testing with public networks, where the number of transactions in 2000 blocks could be so large as to timeout after 30secs even with a fast JSON/RPC endpoint

@codecov-commenter
Copy link

Codecov Report

Merging #29 (327536d) into main (84e3108) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1273      1273           
=========================================
  Hits          1273      1273           
Impacted Files Coverage Δ
internal/ethereum/config.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nguyer nguyer merged commit d227820 into hyperledger:main Sep 2, 2022
@nguyer nguyer deleted the catchup-defaults branch September 2, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants