Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use websocket backend for all rpc calls when it's turned on #147

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Aug 19, 2024

When Websocket is turned on, the code currently only use it for receiving new heads. This PR updated the code to use Websockets for all RPC calls as well so a separate HTTP endpoint is not necessary.

@Chengxuan Chengxuan requested a review from a team as a code owner August 19, 2024 10:03
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chengxuan Chengxuan merged commit 4ee2bbb into hyperledger:main Aug 19, 2024
3 checks passed
@Chengxuan Chengxuan deleted the ws branch August 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants