Faster block detection using WebSocket notifications #142
+320
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
peterbroadhurst
commented
Jun 12, 2024
| "github.com/hyperledger/firefly-transaction-manager/pkg/ffcapi" | ||
| ) | ||
|
|
||
| // blockInfoJSONRPC are the info fields we parse from the JSON/RPC response, and cache | ||
| type blockInfoJSONRPC struct { |
There was a problem hiding this comment.
Moved all this code to the blockListener as it needs to use the same pipe to the same node as the notifications when WebSockets are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to use a WebSocket JSON/RPC connection only for the block listener, and as well as using
eth_newBlockFilterwith polling, to do aneth_subscribeto get shoulder taps as soon as new heads are available.This reduces latency of detection of mining of transactions.