Peer disconnect message - add client info #6947

macfarla · 2024-04-15T05:19:29Z

PR description

Add client name to summary disconnect message - makes cross-referencing disconnects much easier.
Also whether the connection was active.

Fixed Issue(s)

Refs #6945

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>

macfarla · 2024-04-15T06:59:08Z

examples of logs

disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:14:42,237","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x22790fd33ef94696... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:40:21,524","level":"DEBUG","thread":"nioEventLoopGroup-3-6","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xd174777b3f3efa4f... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:01:28,939","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:06:16,053","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x03 USELESS_PEER  - 0x7f2092381e47dabf... Geth/v1.2.9-34b065ae-20230721/linux-amd64/go1.19.11 - 2 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:12:30,168","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x37a0bc5301ae557a... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:20:06,827","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x5476d6ed52c9b07b... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T05:10:46,235","level":"DEBUG","thread":"nioEventLoopGroup-3-3","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x04 TOO_MANY_PEERS  - 0xf64105f40f5533e4... erigon/v2.58.1/linux-amd64/go1.21.6 - 1 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T05:40:28,027","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xdc01223695d49395... bor/v1.2.7/linux-amd64/go1.20.14 - 1 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T06:08:54,482","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x464f5277624ce834... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T06:24:49,875","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xcd6dc7d5e44b5590... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T06:28:44,161","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x03 USELESS_PEER  - 0x87fc72a3d15c69f8... besu/v24.4-develop-9bed81f/linux-x86_64/openjdk-java-21 - 2 peers left","throwable":""}
disconnects-6609-61.log:{"@timestamp":"2024-04-15T06:27:40,759","level":"DEBUG","thread":"nioEventLoopGroup-3-8","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x05 ALREADY_CONNECTED  - 0x87fc72a3d15c69f8... besu/v24.4-develop-9bed81f/linux-x86_64/openjdk-java-21 - 1 peers left","throwable":""}
disconnects-6609-61.log:{"@timestamp":"2024-04-15T06:36:33,373","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x269545a10921e699... bor/v1.2.7/linux-amd64/go1.20.14 - 3 peers left","throwable":""}
disconnects-6609-62.log:{"@timestamp":"2024-04-15T06:28:39,851","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x05 ALREADY_CONNECTED  - 0x87fc72a3d15c69f8... besu/v24.4-develop-9bed81f/linux-x86_64/openjdk-java-21 - 1 peers left","throwable":""}
➜  ~ grep 0xa3435a0155a3e837... disconnects-6609*
disconnects-6609-51.log:{"@timestamp":"2024-04-15T04:58:56,490","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:01:28,904","level":"DEBUG","thread":"nioEventLoopGroup-3-6","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T04:58:56,489","level":"DEBUG","thread":"nioEventLoopGroup-3-6","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:01:28,939","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
➜  ~ grep ac906289e4b disconnects-6609*
disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:51:14,935","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xac906289e4b7f12d... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:51:14,911","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xac906289e4b7f12d... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}

macfarla · 2024-04-15T07:01:11Z

one with empty client info

disconnects-6609-50.log:{"@timestamp":"2024-04-15T06:25:27,150","level":"DEBUG","thread":"nioEventLoopGroup-3-8","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x5680fdd9c1442e60...  - 22 peers left","throwable":""}

Signed-off-by: Sally MacFarlane <[email protected]>

…nect

macfarla · 2024-04-16T11:57:56Z

Note latest commit changes this

"Disconnect - active Connection? true - Outbound - 0x03 USELESS_PEER_USELESS_RESPONSES Useless responses: exceeded threshold - 0x302cf78ac89db83b... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 4 peers left","throwable":""}

to this (easier for log analysis)

{"Disconnect - active Connection? true - Outbound - 0x03 USELESS_PEER_USELESS_RESPONSES - 0xac906289e4b7f12d... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 0 peers left","throwable":""}

* add client info to disconnect message Signed-off-by: Sally MacFarlane <[email protected]> * exclude disconnect reason message since it makes it harder to analyse Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>

add client info to disconnect message

3fa9f13

Signed-off-by: Sally MacFarlane <[email protected]>

macfarla added logging peering labels Apr 15, 2024

macfarla mentioned this pull request Apr 16, 2024

Analyse Inbound Disconnect Reasons Per Client #6945

Closed

macfarla added 2 commits April 16, 2024 21:26

exclude disconnect reason message since it makes it harder to analyse

d40348f

Signed-off-by: Sally MacFarlane <[email protected]>

Merge branch 'main' of github.com:hyperledger/besu into client-discon…

fae7370

…nect

fab-10 approved these changes Apr 16, 2024

View reviewed changes

Merge branch 'main' into client-disconnect

09b43d1

macfarla enabled auto-merge (squash) April 16, 2024 21:23

macfarla merged commit b5b7b9f into hyperledger:main Apr 16, 2024
42 checks passed

macfarla deleted the client-disconnect branch April 17, 2024 00:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Peer disconnect message - add client info #6947

Peer disconnect message - add client info #6947

macfarla commented Apr 15, 2024 •

edited

Loading

macfarla commented Apr 15, 2024

macfarla commented Apr 15, 2024

macfarla commented Apr 16, 2024

Peer disconnect message - add client info #6947

Peer disconnect message - add client info #6947

Conversation

macfarla commented Apr 15, 2024 • edited Loading

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

macfarla commented Apr 15, 2024

macfarla commented Apr 15, 2024

macfarla commented Apr 16, 2024

macfarla commented Apr 15, 2024 •

edited

Loading