Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct prefix on created @type on aries messages. #341

Merged
merged 8 commits into from
Sep 1, 2021

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Aug 30, 2021

Addressing issue #188

Previously Aries messages created by aries-vcx used did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/ prefix for @type attribute.
According to https://github.com/hyperledger/aries-rfcs/blob/08653f21a489bf4717b54e4d7fd2d0bdfe6b4d1a/concepts/0020-message-types/README.md#aries-core-message-namespace the prefix for core aries protocols should be https://didcomm.org/

https://didcomm.org/ is used to namespace protocols defined by the community as "core protocols" or protocols that agents should minimally support.

This PR updates aries-vcx to create messages with the correct prefix.

The support for legacy prefix did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/ is preserved so this PR is not breaking change, however it can be expected the support for this prefix will be removed in future releases.

This PR also adds tests for serialization/deserialization of aries messages in general.

Signed-off-by: Patrik Stas [email protected]

@Patrik-Stas Patrik-Stas requested a review from a team as a code owner August 30, 2021 16:10
@Patrik-Stas Patrik-Stas force-pushed the bugfix/aries_msg_types branch from f261d6c to d7ba70f Compare August 30, 2021 16:15
Signed-off-by: Patrik Stas <[email protected]>
Signed-off-by: Patrik Stas <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #341 (581911b) into main (6cec727) will decrease coverage by 2.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   49.68%   46.84%   -2.85%     
==========================================
  Files         158      102      -56     
  Lines       16857     8044    -8813     
  Branches     3756     2007    -1749     
==========================================
- Hits         8376     3768    -4608     
+ Misses       5847     2894    -2953     
+ Partials     2634     1382    -1252     
Flag Coverage Δ
integration ?
unittests 46.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/messages/a2a/message_family.rs 0.00% <ø> (-75.39%) ⬇️
aries_vcx/src/messages/a2a/mod.rs 100.00% <ø> (+45.85%) ⬆️
aries_vcx/src/messages/a2a/message_type.rs 100.00% <100.00%> (+15.62%) ⬆️
aries_vcx/src/messages/ack.rs 0.00% <0.00%> (-62.97%) ⬇️
aries_vcx/src/messages/connection/invite.rs 0.00% <0.00%> (-58.54%) ⬇️
aries_vcx/src/messages/connection/response.rs 0.00% <0.00%> (-56.89%) ⬇️
...src/handlers/connection/inviter/states/complete.rs 0.00% <0.00%> (-56.67%) ⬇️
aries_vcx/src/messages/connection/request.rs 0.00% <0.00%> (-56.42%) ⬇️
...ation/verifier/states/presentation_request_sent.rs 0.00% <0.00%> (-54.84%) ⬇️
.../src/handlers/connection/inviter/states/invited.rs 0.00% <0.00%> (-53.85%) ⬇️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cec727...581911b. Read the comment docs.

@Patrik-Stas Patrik-Stas requested a review from mirgee August 31, 2021 14:25
Signed-off-by: Patrik Stas <[email protected]>
@mirgee mirgee merged commit 1b11be2 into main Sep 1, 2021
@mirgee mirgee deleted the bugfix/aries_msg_types branch September 1, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants