-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct prefix on created @type on aries messages. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Stas <[email protected]>
f261d6c
to
d7ba70f
Compare
Patrik-Stas
commented
Aug 30, 2021
Signed-off-by: Patrik Stas <[email protected]>
Signed-off-by: Patrik Stas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 49.68% 46.84% -2.85%
==========================================
Files 158 102 -56
Lines 16857 8044 -8813
Branches 3756 2007 -1749
==========================================
- Hits 8376 3768 -4608
+ Misses 5847 2894 -2953
+ Partials 2634 1382 -1252
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Patrik Stas <[email protected]>
Signed-off-by: Patrik Stas <[email protected]>
Signed-off-by: Patrik Stas <[email protected]>
Signed-off-by: Patrik Stas <[email protected]>
mirgee
suggested changes
Sep 1, 2021
Signed-off-by: Patrik Stas <[email protected]>
mirgee
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #188
Previously Aries messages created by
aries-vcx
useddid:sov:BzCbsNYhMrjHiqZDTUASHg;spec/
prefix for@type
attribute.According to https://github.com/hyperledger/aries-rfcs/blob/08653f21a489bf4717b54e4d7fd2d0bdfe6b4d1a/concepts/0020-message-types/README.md#aries-core-message-namespace the prefix for core aries protocols should be
https://didcomm.org/
This PR updates aries-vcx to create messages with the correct prefix.
The support for legacy prefix
did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/
is preserved so this PR is not breaking change, however it can be expected the support for this prefix will be removed in future releases.This PR also adds tests for serialization/deserialization of aries messages in general.
Signed-off-by: Patrik Stas [email protected]