fix: Fix bug in test harness for unstable network #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamHSmith
requested review from
s8sato,
mversic,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
|
Currently the github runners are too slow for all the integration tests to pass. |
nxsaken
previously approved these changes
Aug 19, 2024
SamHSmith
force-pushed
the
fix_unstable_network_test
branch
4 times, most recently
from
95b7ac5 to
cf13629
Compare
|
Is increased timeouts necessary for a fix? |
SamHSmith
force-pushed
the
fix_unstable_network_test
branch
from
cf13629 to
b53d043
Compare
Yes. Not locally, but in the CI it is necessary. |
SamHSmith
force-pushed
the
fix_unstable_network_test
branch
3 times, most recently
from
5c95419 to
7facc48
Compare
|
Note that #4996 switches to a faster runner, and adds retries for |
SamHSmith
force-pushed
the
fix_unstable_network_test
branch
5 times, most recently
from
3c9d72e to
82cd5f6
Compare
SamHSmith
force-pushed
the
fix_unstable_network_test
branch
4 times, most recently
from
18330e7 to
b5f136a
Compare
The faster runner would be a good addition. But I think retries is a very bad idea. |
Erigara
reviewed
Aug 28, 2024
SamHSmith
force-pushed
the
fix_unstable_network_test
branch
from
b5f136a to
ff9827b
Compare
Erigara
reviewed
Aug 28, 2024
Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith
force-pushed
the
fix_unstable_network_test
branch
from
ff9827b to
29fa97f
Compare
s8sato
reviewed
Aug 28, 2024
Erigara
approved these changes
Aug 29, 2024
s8sato
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
The bug was that the node selection for the client was random. This meant that the node the client was using to observe the tests were being frozen. I fixed it so that the client always is connected to the genesis peer which never gets frozen.