Repairing MacOs build on develop

[baziorek]

Description

develop -> master is failing to compile in MacOs: #3960

That is why I need to repair the compilation. It looks that GTest is not compilling for MacOS because compiler is now newer than before (newer compiler usually is more strict). Newer compiler signals some things as warnings, but GTest has -Werror compilation flag. So the solution is to create patch for vcpkg port of gtest to remove the flag (how to create patch is here: https://stackoverflow.com/questions/72588408/vcpkg-how-to-edit-package-file-when-compilation-fails-when-installing-package).

Details of what was done: #3977 (comment)

Linked issue

Closes #{issue_number}

Benefits

We will be able to upgrade main branch with changes from develop

Checklist

• I've read CONTRIBUTING.md
• I've used the standard signed-off commit format (or will squash just before merging)
• All applicable CI checks pass (or I promised to make them pass later)
• (optional) I've written unit tests for the code changes
• I replied to all comments after code review, marking all implemented changes with thumbs up

[baziorek]

It is not ready yet. I need some way to run:

but I unfortunately can not find the option anywhere, could somebody help?

It will be great if somebody runs also:

it is waiting about 12 hours:)

[baziorek]

@safinsaf I hope that this PR (#3977) is fix for: #3960, but to make sure we need to enable checks:

Those checks seems to be enabled only when we want to merge something into main branch, but we need to enable them also for other branches. Unfortunately I'm not CI expert and I can't find where it is enabled only for main. Could You help, please?

[baziorek]

It looks that everything works expect for building on MacOs:

• DCO:D.

When I check details about Building on MacOS I see that building dependencies is fixed (what was problem here: #3960):

Unfortunately Iroha is not building on MacOS (interesting thing is that on Linux it is building). Details of compilation failures:

I see three solutions (I don't know if they will help):

1. Try to downgrade protobuf (it was upgraded here: Trying to upgrade libraries in VCPKG #3862)
2. Can we change compiler on MacOs from clion to gcc10?
3. Try to fix on MacOS with current configuration - but I don't have MacOs, so I can not try that way.

[baziorek]

We have problem, because it is not that easy to fix its, according to possible solutions from another post (#3977 (comment)):

1. Downgrading protobuf is not working, so I'll revert reverting commit (fc4ebec) - didn't help
2. Changing compiler into g++-10 on MacOs - didn't help.

[baziorek]

UPDATE: I noticed that compilation problems are in iroha-lib (what was done during last year internship project): #3977 (comment)

So I decided - let's check if after commenting them everything is going to compile. Unfortunately we faced linkage error:

We can come back to clang compiler and maybe it will pass:)

[baziorek]

Summary (it looks that we fixed with @safinsaf), but the solution is not best possible.
MacOS build was failing, because dependencies were not compiling. So I've created path for VCPKG GTest port and dependencies are building. Another problem was compilation of internship project to create iroha-lib in C++ inside the main repository. As I see probably it never compiled for MacOS (but I can be wrong). The current problem with compilation is connected with examples for the iroha-lib (details of compilation error: #3977 (comment)), unfortunately changing compiler didn't help. So I added some kind of dirty hack - I've added conditional compilation in CMake of the iroha-lib (if(NOT APPLE) compile). Now everything passes.
Unfortunately I can't fix this better way, because I don't have MacOS.

So the question for somebody who is deciding about future of Iroha 1 - can we leave like that?