Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Mercury): adding return_route: all to didcomm Message #80

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Aug 22, 2023

Description

Adding return_route: all to didcomm Message, to align with mediator.

Tested with node demo

  • old code fails expectedly with test message
  • new code test message is sent and received

Jira link

https://input-output.atlassian.net/browse/ATL-5398

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@curtis-h curtis-h self-assigned this Aug 22, 2023
@curtis-h curtis-h changed the title adding return_route: all to didcomm Message feat(Mercury): adding return_route: all to didcomm Message Aug 22, 2023
@github-actions
Copy link

Coverage report

Branches coverage not met for global: expected >=30%, but got 22.63157894736842%

St.
Category Percentage Covered / Total
🔴 Statements 34.89% 1370/3927
🔴 Branches 22.63% 559/2470
🔴 Functions 35.41% 409/1155
🔴 Lines 35.6% 1341/3767

Test suite run success

119 tests passing in 23 suites.

Report generated by 🧪jest coverage report action from fc1f5ca

Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@curtis-h curtis-h merged commit 1972a9e into master Aug 25, 2023
@curtis-h curtis-h deleted the feature/ATL-5398.2 branch August 25, 2023 14:08
atala-dev added a commit that referenced this pull request Aug 28, 2023
# [2.3.0](v2.2.0...v2.3.0) (2023-08-28)

### Bug Fixes

* **docs:** Add static reference to the docs. ([#82](#82)) ([3dda29d](3dda29d))

### Features

* **Mercury:** adding return_route: all to didcomm Message ([#80](#80)) ([1972a9e](1972a9e))
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
# [2.3.0](v2.2.0...v2.3.0) (2023-08-28)

### Bug Fixes

* **docs:** Add static reference to the docs. ([#82](#82)) ([3dda29d](3dda29d))

### Features

* **Mercury:** adding return_route: all to didcomm Message ([#80](#80)) ([1972a9e](1972a9e))
elribonazo added a commit that referenced this pull request Aug 30, 2023
* master:
  chore(release): release 2.3.0 # [2.3.0](v2.2.0...v2.3.0) (2023-08-28)
  feat(Mercury): adding return_route: all to didcomm Message (#80)
  fix(docs): Add static reference to the docs. (#82)
  chore(release): release 2.2.0 # [2.2.0](v2.1.0...v2.2.0) (2023-08-23)
  test: update github pipelines (#77)
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
# [2.3.0](hyperledger-identus/sdk-ts@v2.2.0...v2.3.0) (2023-08-28)

### Bug Fixes

* **docs:** Add static reference to the docs. ([hyperledger-identus#82](hyperledger-identus#82)) ([3dda29d](hyperledger-identus@3dda29d))

### Features

* **Mercury:** adding return_route: all to didcomm Message ([hyperledger-identus#80](hyperledger-identus#80)) ([1972a9e](hyperledger-identus@1972a9e))

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants