Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Add Proper Nodejs support + refactor into SRC #58

Merged
merged 9 commits into from
May 23, 2023

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented May 19, 2023

Description

Several issues raise when using the root folder as part of the source, in order to do that I've just moved all the sources into src and then updated the corresponding paths on all the needed files.

Run the tests in nodejs and manually in the browser and everything is running okey.
Also now from the test-demo example application we can directly run all the flow, no need to instanciate a browser anymore.

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

Copy link
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🙌

I just added small README update on how to run demo apps.

@elribonazo elribonazo merged commit 7f04024 into master May 23, 2023
@elribonazo elribonazo deleted the feature/ATL-4655 branch May 23, 2023 11:24
atala-dev added a commit that referenced this pull request May 31, 2023
## [2.0.1](v2.0.0...v2.0.1) (2023-05-31)

### Bug Fixes

* add support for Base64 in PickupRunner ([#52](#52)) ([4d81061](4d81061))
* **agent:** Improve unit testing for protocols. ([#56](#56)) ([4049258](4049258))
* **apollo:** Create keyPair from privateKey, support ed25519 and x25519 keyCurves. ([#57](#57)) ([29b655e](29b655e))
* **apollo:** createKeyPairFromPrivateKey update impl to not use the seed and fix mercury secretResolver impl ([#50](#50)) ([8db08b3](8db08b3))
* browser sqlite storage issue ([#49](#49)) ([a535882](a535882))
* **didcomm:** Add didcomm packages as dependencies  ([#60](#60)) ([a0ba3b6](a0ba3b6))
* **docs:** polishing documentation ([#48](#48)) ([19fa64d](19fa64d))
* improve build process and readme ([#61](#61)) ([a090f9c](a090f9c))
* Index access. ([#44](#44)) ([2d47c50](2d47c50))
* pluto module finding namespace ([#55](#55)) ([5b23f7c](5b23f7c))
* pluto sqljs loader in nodejs ([#54](#54)) ([11afc4f](11afc4f))
* **sdk:** Add Proper Nodejs support + refactor into SRC ([#58](#58)) ([7f04024](7f04024))
* **sdk:** Adding full support for browsers and nodejs platforms. ([#59](#59)) ([2e83cba](2e83cba))
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
…identus#58)

Co-authored-by: Milos Dzepina <[email protected]>
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
## [2.0.1](hyperledger-identus/sdk-ts@v2.0.0...v2.0.1) (2023-05-31)

### Bug Fixes

* add support for Base64 in PickupRunner ([hyperledger-identus#52](hyperledger-identus#52)) ([4d81061](hyperledger-identus@4d81061))
* **agent:** Improve unit testing for protocols. ([hyperledger-identus#56](hyperledger-identus#56)) ([4049258](hyperledger-identus@4049258))
* **apollo:** Create keyPair from privateKey, support ed25519 and x25519 keyCurves. ([hyperledger-identus#57](hyperledger-identus#57)) ([29b655e](hyperledger-identus@29b655e))
* **apollo:** createKeyPairFromPrivateKey update impl to not use the seed and fix mercury secretResolver impl ([hyperledger-identus#50](hyperledger-identus#50)) ([8db08b3](hyperledger-identus@8db08b3))
* browser sqlite storage issue ([hyperledger-identus#49](hyperledger-identus#49)) ([a535882](hyperledger-identus@a535882))
* **didcomm:** Add didcomm packages as dependencies  ([hyperledger-identus#60](hyperledger-identus#60)) ([a0ba3b6](hyperledger-identus@a0ba3b6))
* **docs:** polishing documentation ([hyperledger-identus#48](hyperledger-identus#48)) ([19fa64d](hyperledger-identus@19fa64d))
* improve build process and readme ([hyperledger-identus#61](hyperledger-identus#61)) ([a090f9c](hyperledger-identus@a090f9c))
* Index access. ([hyperledger-identus#44](hyperledger-identus#44)) ([2d47c50](hyperledger-identus@2d47c50))
* pluto module finding namespace ([hyperledger-identus#55](hyperledger-identus#55)) ([5b23f7c](hyperledger-identus@5b23f7c))
* pluto sqljs loader in nodejs ([hyperledger-identus#54](hyperledger-identus#54)) ([11afc4f](hyperledger-identus@11afc4f))
* **sdk:** Add Proper Nodejs support + refactor into SRC ([hyperledger-identus#58](hyperledger-identus#58)) ([7f04024](hyperledger-identus@7f04024))
* **sdk:** Adding full support for browsers and nodejs platforms. ([hyperledger-identus#59](hyperledger-identus#59)) ([2e83cba](hyperledger-identus@2e83cba))

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants